Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA] Make It Standard and Simpler: Buttons on Edit Toolbar, View Toolbar, Editor Toolbar #8804

Open
kookma opened this issue Dec 6, 2024 · 4 comments

Comments

@kookma
Copy link
Contributor

kookma commented Dec 6, 2024

Is your feature request related to a problem? Please describe.

  • Adding a new Editor Toolbar button is easy and there is quick tutorial with automatic creation of toolbar button (Thanks to @pmario)
  • The Editor Toolbar button is the standard, easiest and very flexible
    • The body only keeps the actions, no need for button, and all headaches
    • The fields keep conditions, caption, description, icon, color, ...

Describe the solution you'd like

  • Let's have a unique, standard procedure for creating UI buttons for editor, edit and view toolbars
  • Later on, this procedure may be extended to other UI buttons

The Editor Toolbar Button Anatomy
image

What do you think?

@pmario
Copy link
Member

pmario commented Dec 6, 2024

I am not 100% sure, what you want to achieve, but I think I have a good guess.

I could think of a new [add button] button at the ControlPanel -> Appearence -> Toolbars tab, which allows us to create "new boilerplate" buttons, where users "only" have to fill in the needed info. All the possible / needed fields could be predefined, similar to the editor-toolbar example you mentioned.

image

The hard work will be "good documentation" near the new [add button] button.

I think in combination with the upcoming lucide-icon library editions we should also not have an icon-shortage ;)

@pmario
Copy link
Member

pmario commented Dec 6, 2024

  • Let's have a unique, standard procedure for creating UI buttons for editor, edit and view toolbars

Since the page-toolbar, tiddler-toolbar and the edit-toolbar buttons are slightly different, we will probably need 3 different procedures and "boilerplate" templates.

Especially the connection between the toolbar buttons and keyboard-shortcuts will need special attention for the docs.

@kookma
Copy link
Contributor Author

kookma commented Dec 6, 2024

I am not 100% sure, what you want to achieve, but I think I have a good guess.

I mean to have a standard procedure. One form of implementation. In more precise words:

  • have text field for actions
  • no need to add buttons manually
  • have all configurations like icon, color, caption, hint, ... in fields

This is what we have for Editor Toolbar.

Right now every UI button category has a different way of implementation

@kookma
Copy link
Contributor Author

kookma commented Dec 6, 2024

I could think of a new [add button] button at the ControlPanel -> Appearence -> Toolbars tab, which allows us to create "new boilerplate" buttons, where users "only" have to fill in the needed info. All the possible / needed fields could be predefined, similar to the editor-toolbar example you mentioned.

Good idea, I support this. This lets average users to add UI buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants