Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tiddler Title area DOM elements can be optimized #8742

Open
pmario opened this issue Nov 13, 2024 · 5 comments
Open

[BUG] Tiddler Title area DOM elements can be optimized #8742

pmario opened this issue Nov 13, 2024 · 5 comments

Comments

@pmario
Copy link
Member

pmario commented Nov 13, 2024

Describe the bug

The tiddler title area contains several reveal-widget-DIVs, where the first child also is a DIV. The child DIV is redundant.

  1. DIV artefact from the "tiddler fold state" -> IMO this one should use <%if %>, so go away. Only show it when needed.
  2. The subtitle reveal can stay, but can get new classes: class="tc-subtitle tc-clearfix" -> So redundant child can go away
  3. Same as 2. but with tc-tag-wrapper

grafik

Expected behavior

Redundant child widgets should be gone.

TiddlyWiki Configuration

v5.3.5
v5.3.6-pre

@pmario pmario changed the title [BUG] [BUG] Tiddler Title area DOM elements can be optimized Nov 13, 2024
@Jermolene
Copy link
Member

Hi @pmario while it is frustrating that we have those additional elements, I don't think it is worth the risk of making a change if there is no other user benefit apart from the simplification. So, for example, this might be something to fix at the same time as providing a UI to allow users to disable and reorder the tiddler segments.

@pmario
Copy link
Member Author

pmario commented Nov 14, 2024

The problem is only there with the new test-case templates. So there should be no side effects to other elements.

@Jermolene
Copy link
Member

Hi @pmario the OP doesn't mention the testcase widget or testcase templates

@pmario
Copy link
Member Author

pmario commented Nov 15, 2024

uuups. I did respond with the wrong issue in mind. Sorry.
My response was targeted to [BUG] testcase-widget produces redundant HMTL tags: P DIV DIV P #8741

@Jermolene
Copy link
Member

Thanks @pmario that makes sense, no worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants