feat(coverAmbience): full rewrite #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there are also some type warnings, these will be fixed with the spicetify types update |
rn you can replace the wrapper to test the extension |
SunsetTechuila
changed the title
|
@Theblockbuster1 hello! you have no plans to merge this, right? |
|
Hi @SunsetTechuila, I'm sorry about the delays, things got in the way. Thank you for the pull request, even though its closed by now lol. I'm quite unfamiliar with React/TypeScript, so I think that merging it would've been a problem for me to maintain myself anyway. I may get back into things and try implementing your bug fixes into the extension again, I'll see. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
everything is ready, but the next version of spicetify is required
fixes #18
fixes #31
fixes #33