fixes join.py and split.py action and requirements error #12438
+34
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
sanks011
changed the title
Kaaserne
reviewed
Dec 16, 2024
strings/join.py
Outdated
| if not all(isinstance(word_or_phrase, str) for word_or_phrase in separated): | ||
| raise Exception("join() accepts only strings") | ||
|
|
||
| joined = separator.join(separated) |
There was a problem hiding this comment.
Question about this join though. Isn't the point of this repository to show possible implementations of python functions? Because if that's the case, I was wondering why the join function now internally uses str.join?
There was a problem hiding this comment.
okay I understood! Now I'll try to implement something which manually constructs the resulting string without relying on Python's built-in str.join()
for more information, see https://pre-commit.ci
sanks011
commented
Dec 18, 2024
| for i, element in enumerate(separated): | ||
| result += element | ||
| if i < len(separated) - 1: # Add separator only between elements | ||
| result += separator | ||
|
|
There was a problem hiding this comment.
@Kaaserne can you please review it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes #12408
Fixes #12403
Fixes #12346
Checklist:
For #12408
Previously it was
Now
new version utilizes Python's built-in separator.join(separated) to join the strings. This method is more efficient and handles edge cases (like empty strings) properly without needing manual intervention and all() function to check if all elements in the separated list are strings before proceeding. This avoids checking each element individually during the loop.
For #12403
Previously it was
Now
The updated code includes a check at the end (if string and string[-1] == separator) to ensure that if the string ends with a separator, an empty string '' is added to the list. This ensures the behavior matches Python's built-in split method.
For #12346
