Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run clang-tidy changes on a PR #2501

Closed
wants to merge 7 commits into from
Closed

feat: run clang-tidy changes on a PR #2501

wants to merge 7 commits into from

Conversation

Panquesito7
Copy link
Member

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Panquesito7 Panquesito7 added the enhancement New feature or request label Jul 6, 2023
@Panquesito7 Panquesito7 requested a review from tjgurwara99 July 6, 2023 04:51
realstealthninja
realstealthninja previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

realstealthninja
realstealthninja approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Sep 12, 2023
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@tjgurwara99 tjgurwara99 Awaiting requested review from tjgurwara99

@alexpantyukhin alexpantyukhin Awaiting requested review from alexpantyukhin

Assignees
No one assigned
Labels
enhancement New feature or request stale Author has not responded to the comments for over 2 weeks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create a pull request for the Clang Tidy
2 participants
@Panquesito7 @realstealthninja