Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propogation of Secret to Forks #108

Open
Kannav02 opened this issue Nov 29, 2024 · 3 comments
Open

Propogation of Secret to Forks #108

Kannav02 opened this issue Nov 29, 2024 · 3 comments

Comments

@Kannav02
Copy link
Collaborator

The CI pipeline prevents any PRs coming from a fork to pass through because the secrets are not being propagated to the forks

an example of the affected lines can be seen here

Expected/Original Behaviour

Screenshot 2024-11-28 at 8 44 09 PM

Unexpected / Forked Repo Behaviour

Screenshot 2024-11-28 at 8 44 17 PM

I know what line is causing this issue and would like to propose a fix for the same

  • The events will now get triggered by the pull_request_target event, which will allow the CI pipeline to run in the context of the upstream repo which in our case is the original repo with the secrets
  • now since this might also lead to the secrets being misused by unknown contributors, what we could do is also add the "Approval to run the CI by maintainers for the first-time contributors"
@Kannav02 Kannav02 assigned Kannav02 and unassigned Kannav02 Nov 29, 2024
@Kannav02
Copy link
Collaborator Author

Kannav02 commented Dec 1, 2024

I believe i can even incorporate further details about how a user can setup the ENV variables like the google_service_key in this issue ,as the documentation right now is unclear, even i had issues when i first tried to setup my variables, would you want me to also work on that @luarss ?

@Kannav02
Copy link
Collaborator Author

any updates on this @luarss ?

@luarss
Copy link
Collaborator

luarss commented Dec 18, 2024

I believe i can even incorporate further details about how a user can setup the ENV variables like the google_service_key in this issue ,as the documentation right now is unclear, even i had issues when i first tried to setup my variables, would you want me to also work on that @luarss ?

Yes, documentation is welcome!

For now, I think I will revise the secrets-based workflow to be only run on main branch, so that PRs can still run as normal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants