Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong representation of window #824

Open
adrian-widmer opened this issue May 22, 2024 · 12 comments
Open

[Bug]: Wrong representation of window #824

adrian-widmer opened this issue May 22, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@adrian-widmer
Copy link

adrian-widmer commented May 22, 2024

What happened?

I integrated the viewer of That Open Company in our application (Angular application written in TypeScript) and if I load an IFC model that we created in ArchiCAD, two of the windows are shown in a very strange way (see attached images - issue1, issue2). In ArchiCAD as well as in another viewer (BIMCollabZoom), the model looks as expected (see attached image - normal). So, I'm not sure what exactly is wrong in the rendering of this model but there seems to be a bug. Could someone have a look at this or get in touch with me if further information are needed. I could also share the model if that would help, just let me know so that I can share it privately.

Hint: I load it as well on the demo page (https://thatopen.github.io/engine_web-ifc/demo/) and checked how it looks and the issue is the same as in my application.

Issue1
issue1

Issue 2
issue2

normal (working in BIMCollabZoom)
normal

Version

0.0.53

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Anything else?

No response

@adrian-widmer adrian-widmer added the bug Something isn't working label May 22, 2024
@QuimMoya
Copy link
Contributor

Can you share the model?

@adrian-widmer
Copy link
Author

Yes, sure. Is there an easy way I can share the model with you privately?

@QuimMoya
Copy link
Contributor

Please send it to [email protected], specifying the issue it relates to, and mention that this model is for @QuimMoya.

@adrian-widmer
Copy link
Author

Ok, sure will send it right away. Thanks.

@QuimMoya
Copy link
Contributor

Last improvements in fuzzy bools library greatly reduced the issues in your model, still some bugs anyway.
image

@adrian-widmer
Copy link
Author

adrian-widmer commented Sep 12, 2024

@QuimMoya Thanks for the input and sorry for getting back to you that late but I either didn't see the notification or it went to my spam somehow. So, that means you improved already a bit in this direction. I actually just had similar if not even more severe viewing issues recently where a model looked like this:
Screenshot 2024-09-12 at 10 35 18

So, it seems that several things can't be shown correctly. Since you already started to improve several things, do you know why it looks so weird?

...because this is quite a blocker for us because customers will not gain any trust in a viewer that shows models in such a funky way

I will send you the file again via mail so that you have everything you need to localise the issue.

BTW, I use these versions if that helps as information:
"@thatopen/components": "^2.2.3",
"@thatopen/components-front": "^2.0.6",
"@thatopen/fragments": "^2.0.4",
"@thatopen/ui": "^2.0.8",
"@thatopen/ui-obc": "^2.0.9",
"bim-fragment": "^1.5.0",
"three": "^0.160.1",
"web-ifc": "^0.0.57",

In what version of web-ifc are your changes included?

@adrian-widmer
Copy link
Author

@QuimMoya Hey a guy from the That Open Community had a look into the issue and gave the following feedback that might also help in this case:
I did take a quick look, I'm not sure what the cause is

I hope that helps ;-)

@agviegas
Copy link
Collaborator

Model privately available here

@adrian-widmer
Copy link
Author

Hey @QuimMoya, did you have the chance to look into this issue by any chance?
It seems that quite some people have similar issues with this. If I can help in any way let me know.

@HoyosJuan
Copy link
Member

I relate here the conversation in the community.

@QuimMoya
Copy link
Contributor

QuimMoya commented Oct 1, 2024

image
It is improving

@QuimMoya
Copy link
Contributor

QuimMoya commented Oct 1, 2024

This model also improved

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants