Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ts + telegram-apps + vue has bug which make the url messy #588

Open
kuchaguangjie opened this issue Dec 6, 2024 · 9 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@kuchaguangjie
Copy link

Telegram Application

Telegram Desktop

Describe the Bug

I set base as base: 'https://778b8bd1f0.tapps.global/latest',
after mate deploy upload, when access: https://778b8bd1f0.tapps.global/latest/index.html
it become:
https://778b8bd1f0.tapps.global/https://778b8bd1f0.tapps.global/latest/latest/index.html

I also tried to make base to use '/' or '/xxx', none would work.

But the doc says I should use base: 'https://778b8bd1f0.tapps.global/latest', and it works for jquery.
So, I think the vue version has some bug.

To Reproduce

Steps to reproduce the behavior:
create a project using ts + telegram-apps + vue, change base url as doc described, then you will see.

Expected Behavior

It should work in tg

@kuchaguangjie kuchaguangjie added the bug Something isn't working label Dec 6, 2024
@kuchaguangjie
Copy link
Author

I did the same test for ts + telegram-apps + react, it works fine.
So, please fix vue, if you don't plan to support vue, just remove it from the choice, to save people's time.

@kuchaguangjie
Copy link
Author

I did the same test for ts + telegram-apps + jquery, it also works fine.

@kuchaguangjie
Copy link
Author

1
BTW, for some choice, some icon is missing. above is for js + telegram-apps + none

@kuchaguangjie
Copy link
Author

kuchaguangjie commented Dec 6, 2024

BTW, even for the react project, the generated README is wrong about the base:
image

Instead, the doc is correct, please make these docs & readme & code consistent.

@update: I see, the README is using github pages to upload, while the doc is using mate to upload.
I think it would be better to make it consistent. and put them in one place.

@heyqbnk
Copy link
Member

heyqbnk commented Dec 6, 2024

@dnischeta hey! Could you, please, take a look?

@kuchaguangjie
Copy link
Author

kuchaguangjie commented Dec 6, 2024

I tried to use github pages to upload as README describes:
image

Upload success.

The page is not shown correctly from browser or tg mini.
image

image

So, if the github pages solution doesn't work, should update the generated README.
Never duplicated things, just keep them in one place, and use links instead, so that it will always be up to date, even as time goes.

If github page doesn't work, then should remove following from package.json:

"deploy": "gh-pages -d dist",

@kuchaguangjie
Copy link
Author

I find it easier to build via mate using a Makefile:

build:
	pnpm build

deploy: build
	pnpm mate deploy upload

Run make deploy, then it will build & deploy.

@dnischeta
Copy link
Contributor

@kuchaguangjie , hi!

Could you please split that issue into separate issues for separate packages, it's really hard to read and extract problem you're facing with.

I'll reply about Vue.js template.

I've checked Vue template and configured deployment according to README, it works for both manual deployment (gh-pages) and GitHub actions (see https://github.com/dnischeta/vue-tma-issue). Could you provide a reproduction for the issue you're facing with?

So, please fix vue, if you don't plan to support vue, just remove it from the choice, to save people's time.

It works fine.

I see, the README is using github pages to upload, while the doc is using mate to upload.
I think it would be better to make it consistent. and put them in one place.

Generally, it your choice how to deploy your app: using GitHub actions or any other hosting. README focuses on GitHub pages, because it's easy to configure and run.

@kuchaguangjie
Copy link
Author

kuchaguangjie commented Dec 9, 2024

vue doesn't work. I explained the steps and showed the screenshot how it doesn't work. the exact same step works for react & jquery, but not vue.
I tried several times back & forth, I'm pretty sure about this.

about github pages, I tried several times, It got 404, but since mate cmd works for react, I don't care about that any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants