From ee19de609bdbb3880639769297830be5349b86e3 Mon Sep 17 00:00:00 2001 From: Jinny Date: Wed, 5 Oct 2022 02:20:11 +0900 Subject: [PATCH 1/4] =?UTF-8?q?feat:=20:sparkles:=20slider=20lazy=20loadin?= =?UTF-8?q?g=20=EC=B6=94=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/common/MainSlider.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/common/MainSlider.tsx b/src/components/common/MainSlider.tsx index 4e97ec1..794bfae 100644 --- a/src/components/common/MainSlider.tsx +++ b/src/components/common/MainSlider.tsx @@ -54,6 +54,8 @@ function MainSlider(props: MainSliderProps) { prevEl: prevRef.current, // 이전 버튼 nextEl: nextRef.current, // 다음 버튼 }, + lazy: true, + preloadImages: false, pagination: { clickable: false, renderBullet: (index, className) => From 2d1a82c29257adf3e0ec5c07930900e3386dd3c4 Mon Sep 17 00:00:00 2001 From: Jinny Date: Wed, 5 Oct 2022 02:27:17 +0900 Subject: [PATCH 2/4] =?UTF-8?q?edit:=20:fire:=20=EC=A0=81=EC=A0=88?= =?UTF-8?q?=ED=95=98=EC=A7=80=20=EC=95=8A=EC=9D=80=20li=20=ED=83=9C?= =?UTF-8?q?=EA=B7=B8=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/common/Footer.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/common/Footer.tsx b/src/components/common/Footer.tsx index f868b0b..25f7742 100644 --- a/src/components/common/Footer.tsx +++ b/src/components/common/Footer.tsx @@ -102,7 +102,7 @@ const MobileFontStyle = css` line-height: 7px; `; -const ContactTitle = styled.div` +const ContactTitle = styled.b` width: 7.7rem; font-weight: 600; font-size: 1.4rem; @@ -116,7 +116,7 @@ const ContactTitle = styled.div` } `; -const ContactContent = styled.li` +const ContactContent = styled.span` flex: 1; list-style: none; font-weight: 400; @@ -153,7 +153,7 @@ const RightFooterWrapper = styled.div` } `; -const RightFooter = styled.li` +const RightFooter = styled.span` list-style: none; display: flex; justify-content: space-between; From 393932e41d9079a48b71fa3fc81aa3aa0fe919a8 Mon Sep 17 00:00:00 2001 From: Jinny Date: Wed, 5 Oct 2022 03:04:22 +0900 Subject: [PATCH 3/4] =?UTF-8?q?edit:=20:fire:=20=EC=A0=91=EA=B7=BC?= =?UTF-8?q?=EC=84=B1=20=EA=B4=80=EB=A0=A8=20=EC=9A=94=EC=86=8C=20=EC=88=98?= =?UTF-8?q?=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. a 태그에 aria-label 추가 2. input 태그에 label을 명시적으로 추가할 것 => 하지 못한다면 title 속성은 제공하자. 3. heading 태그는 descending 한 구조로 작성하자. 4. html lang 속성을 추가하자. --- src/components/ThemeSelector/index.tsx | 2 +- src/components/common/Banner.tsx | 2 +- src/components/common/Navbar/GlobalNav/Desktop.tsx | 2 +- src/components/common/Navbar/NavSearch/index.tsx | 7 ++++++- src/pages/_document.tsx | 3 ++- 5 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/components/ThemeSelector/index.tsx b/src/components/ThemeSelector/index.tsx index 68a09dd..64bfeac 100644 --- a/src/components/ThemeSelector/index.tsx +++ b/src/components/ThemeSelector/index.tsx @@ -18,7 +18,7 @@ function ThemeSelector() { const isValidCurrentTheme = !currentTheme || typeof currentTheme === 'string'; return ( -

테마별 소품샵

+

테마별 소품샵

{isValidCurrentTheme && category.map((themeType) => ( diff --git a/src/components/common/Banner.tsx b/src/components/common/Banner.tsx index db0978f..de464ae 100644 --- a/src/components/common/Banner.tsx +++ b/src/components/common/Banner.tsx @@ -12,7 +12,7 @@ function Banner(props: BannerProps) { if (href) { return ( - + ); } diff --git a/src/components/common/Navbar/GlobalNav/Desktop.tsx b/src/components/common/Navbar/GlobalNav/Desktop.tsx index 3b826b1..caa9c2a 100644 --- a/src/components/common/Navbar/GlobalNav/Desktop.tsx +++ b/src/components/common/Navbar/GlobalNav/Desktop.tsx @@ -36,7 +36,7 @@ function GlobalNavDesktop(props: NavProps) { - + diff --git a/src/components/common/Navbar/NavSearch/index.tsx b/src/components/common/Navbar/NavSearch/index.tsx index dff1fee..275d8ec 100644 --- a/src/components/common/Navbar/NavSearch/index.tsx +++ b/src/components/common/Navbar/NavSearch/index.tsx @@ -58,7 +58,12 @@ function NavSearch() { - + {isOpen && ( {results.length > 0 ? ( diff --git a/src/pages/_document.tsx b/src/pages/_document.tsx index ddfb1f9..142462d 100644 --- a/src/pages/_document.tsx +++ b/src/pages/_document.tsx @@ -37,7 +37,7 @@ export default class MyDocument extends Document { render() { return ( - +