Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This middleware breaks default throttling #50

Open
3hhh opened this issue Sep 26, 2020 · 0 comments
Open

This middleware breaks default throttling #50

3hhh opened this issue Sep 26, 2020 · 0 comments

Comments

@3hhh
Copy link

3hhh commented Sep 26, 2020

You set a per-proxy download_slot at [1].

Essentially that means:
Throttling works per-proxy (cf. [2], same for 'DOWNLOAD_DELAY` et al) and not per destination host anymore (that would be the default).

Since most users will have >> 100 proxies, you'll hammer the target host with >> 100 requests at once.
So the user can be nice to his proxy provider, but not to the destination host.

[1] https://github.com/TeamHG-Memex/scrapy-rotating-proxies/blob/master/rotating_proxies/middlewares.py#L146
[2] https://github.com/scrapy/scrapy/blob/master/scrapy/extensions/throttle.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant