First pass at integrating AdvantageKit into MaroonFramework #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto integrate-advantagekit
dejabot
commented
Dec 30, 2023
rcahoon
requested changes
Jan 5, 2024
…nto integrate-advantagekit
rcahoon
reviewed
Jan 15, 2024
|
Thx! PTAL? |
|
Can you confirm that it works in the simulator now? |
|
thx! yes, confirmed. in doing some additional testing, I found that I missed Logger.logRaw() - updated. |
rcahoon
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass (for initial feedback) of integrating AdvantageKit into MaroonFramework.
Current MaroonFramework logs will also be written to WPI logs.
DriverStation will log joystick input, to allow for replay analysis.
Tested on BurroBot. Can view console logs and joystick input (replay).
Still need to test out various permutations of SD cards/sizes/formats - and verify that logs still get written to RoboRio if USB drive is missing.
Future work will start logging swerve, odometry, and ideally mechanisms to allow for analysis and tuning through replay.
This change is