Refactor swerve code to use new SwerveModule class #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prepare for AdvantageKit integration by refactoring swerve code into separate SwerveModules, one for each corner.
qntmcube
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactors swerve code in Drive by separating out each drive+steer+encoder in a physical swerve module to be encapsulated in a new SwerveModule class. this both tidies up Drive and more significantly helps us prepare for AdvantageKit integration, so we can use AdvantageScope to plot and analyze our swerve behavior.
How Has This Been Tested?
this will need to be tested on Gatorade, once programming has access to Gatorade again.