Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piece repository delete request enhancement #223

Open
tdari opened this issue Jan 29, 2024 · 3 comments
Open

Piece repository delete request enhancement #223

tdari opened this issue Jan 29, 2024 · 3 comments
Assignees
Labels
frontend Frontend related issues

Comments

@tdari
Copy link
Contributor

tdari commented Jan 29, 2024

Currently when you want to delete a repository from the platform UI shows a generic toast and i think it is not helpful. Imagine when you have a lot of workflows and you get this warning.
image
My proposal is to delete all workflows containing this repository by asking the user.

@vinicvaz
Copy link
Collaborator

@luiztauffer @nathan-vm
What you think about that?
Maybe we can have something like a confirmation modal asking if the user want to delete all workflows with a relation to the repository to be deleted, them we can cascade delete them.

@luiztauffer
Copy link
Member

we definitely don't want to just delete with one step.
Perhaps we could have something similar to a dialog with:

The following workflows are dependent on this repository, and will be deleted together with it:
- workflow 1
- workflow 2
- workflow 3
...

To delete the `repository name` and all the workflows above, confirm writing the name of the repository below:
___________________________
confirm     cancel

@nathan-vm
Copy link
Collaborator

I agree, we need a very explicit confirmation modal.

I'll work on this once I finish the refactoring on front-end storage.

@nathan-vm nathan-vm self-assigned this Jan 30, 2024
@nathan-vm nathan-vm added the frontend Frontend related issues label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend related issues
Projects
None yet
Development

No branches or pull requests

4 participants