-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query-core): allow function value of notifyOnChangeProps
query option to return undefined
#7441
base: main
Are you sure you want to change the base?
Conversation
…option to return `undefined` `undefined` is a valid return value for the function value of `notifyOnChangeProps`. See linked issue for more details. Fixes TanStack#7426.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e28ea02:
|
can you amend the signature in the docs as well please? |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e28ea02. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution Sent with 💌 from NxCloud. |
also the jsdoc please: query/packages/query-core/src/types.ts Lines 319 to 326 in 3a8c2b1
|
undefined
is a valid return value for the function value ofnotifyOnChangeProps
. See linked issue for more details.Fixes #7426.