You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, get_dataset_splits() in our datasets is a static method (@staticmethod), but it would be more appropriate to have it marked as a class method (@classmethod).
The following example shows the difference between these two:
In our datasets, x corresponds to get_dataset_splits and y corresponds to get_default_fields. The issue is that our current pattern doesn't support overriding get_default_fields by a subclass as can be seen in the example above (replace print with return fields), without overriding get_dataset_splits as well. We have this scenario in the SNLI dataset so this is the main reason why I'm opening this issue.
The text was updated successfully, but these errors were encountered:
Currently,
get_dataset_splits()
in our datasets is a static method (@staticmethod
), but it would be more appropriate to have it marked as a class method (@classmethod
).The following example shows the difference between these two:
B.x()
printsAy
B.x()
printsBy
In our datasets,
x
corresponds toget_dataset_splits
andy
corresponds toget_default_fields
. The issue is that our current pattern doesn't support overridingget_default_fields
by a subclass as can be seen in the example above (replaceprint
withreturn fields
), without overridingget_dataset_splits
as well. We have this scenario in the SNLI dataset so this is the main reason why I'm opening this issue.The text was updated successfully, but these errors were encountered: