Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract tabular dataset loading #274

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Abstract tabular dataset loading #274

wants to merge 10 commits into from

Conversation

mttk
Copy link
Member

@mttk mttk commented Jan 14, 2021 •
edited
Loading

Closes #273

Draft, function calls and names subject to change, but the gist is here.

@mttk mttk mentioned this pull request Jan 14, 2021
Open
@mttk mttk self-assigned this Jan 14, 2021
ivansmokovic
ivansmokovic requested changes Jan 14, 2021
View reviewed changes
Copy link
Collaborator

@ivansmokovic ivansmokovic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Some nitpicks.
Not an actual review, just wanted to point some things out.

podium/datasets/arrow_tabular_dataset.py Outdated Show resolved Hide resolved
podium/datasets/tabular_dataset.py Outdated Show resolved Hide resolved
podium/datasets/tabular_dataset.py Show resolved Hide resolved
podium/datasets/tabular_dataset.py Outdated Show resolved Hide resolved
@mttk mttk requested a review from ivansmokovic January 16, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariosasko mariosasko Awaiting requested review from mariosasko

@FilipBolt FilipBolt Awaiting requested review from FilipBolt

@ivansmokovic ivansmokovic Awaiting requested review from ivansmokovic

Requested changes must be addressed to merge this pull request.

Assignees

@mttk mttk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove from_tabular_file in ArrowDataset
2 participants
@mttk @ivansmokovic