Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The proxy server in vscode settings, blocks access to tabby on localhost #3360

Open
n-r-w opened this issue Nov 1, 2024 · 3 comments
Open
Labels
question Further information is requested

Comments

@n-r-w
Copy link

n-r-w commented Nov 1, 2024

If proxy is enabled in vs code (http.proxy option), and tabby is installed locally, then it is impossible to connect to it.

vscode config:

    "http.proxyStrictSSL": false,
    "http.proxyAuthorization": null,
    "http.proxySupport": "on",
    "http.proxy": "http://10.222.3.4:2080",

tabby started:

Version 0.19.0
🚀 Listening at http://0.0.0.0:8080

tabby logs:

024-11-02 00:22:01.498 [info] [Info  - 12:22:01 AM] [Proxy] Using proxy http://10.222.3.4:2080.
2024-11-02 00:22:01.519 [info] [Debug - 12:22:01 AM] [TabbyApiClient] Health check request: GET http://127.0.0.1:8080/v1/health. [de789c23-695c-45d1-8851-600cb4450146]
2024-11-02 00:22:01.520 [info] [Debug - 12:22:01 AM] [TabbyLSP] Internal components initialized.
2024-11-02 00:22:01.521 [info] [Debug - 12:22:01 AM] [TabbyLSP] Initializing feature components...
2024-11-02 00:22:01.521 [info] [Info  - 12:22:01 AM] [RecentlyChangedCodeSearch] Created code search engine for recently changed files.
2024-11-02 00:22:01.522 [info] [Debug - 12:22:01 AM] [TabbyLSP] Feature components initialized.
2024-11-02 00:22:01.524 [info] [Info  - 12:22:01 AM] [TabbyLSP] Initialize done.
2024-11-02 00:22:01.528 [info] [Tabby] Tabby extension activated.
2024-11-02 00:22:01.528 [info] [Error - 12:22:01 AM] [TabbyApiClient] Health check request failed. [de789c23-695c-45d1-8851-600cb4450146] {
  "error": {}
}
@zwpaper
Copy link
Member

zwpaper commented Nov 2, 2024

hi @n-r-w, thanks for trying Tabby,

After you set the proxy, all network connections go through the proxy even localhost, so you might need to add a noproxy setting to bypass the proxy for localhost.

I also found vscode has mark this proxy settings legacy, you can check more on https://code.visualstudio.com/docs/setup/network

@zwpaper zwpaper added question Further information is requested and removed bug-unconfirmed labels Nov 2, 2024
@n-r-w
Copy link
Author

n-r-w commented Nov 2, 2024

hi @n-r-w, thanks for trying Tabby,

After you set the proxy, all network connections go through the proxy even localhost, so you might need to add a noproxy setting to bypass the proxy for localhost.

I also found vscode has mark this proxy settings legacy, you can check more on https://code.visualstudio.com/docs/setup/network

On the one hand, it sounds logical. But on the other hand, tabby uses this "outdated" http.proxy parameter, but ignores http.NoProxy settings.

@n-r-w
Copy link
Author

n-r-w commented Nov 2, 2024

It seems that in this merge request they forgot about http.NoProxy https://github.com/TabbyML/tabby/pull/2921/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants