Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type of target from PrivateChannel #226

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix type of target from PrivateChannel #226

wants to merge 2 commits into from

Conversation

sileence114
Copy link
Contributor

  • 添加 PrivateChannel.target: User
  • 将 PrivateChannel.target_info 标记为 deprecated

@sileence114 sileence114 mentioned this pull request Feb 6, 2024
Closed
TWT233
TWT233 requested changes Feb 24, 2024
View reviewed changes
Copy link
Owner

@TWT233 TWT233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有两个小问题

khl/channel.py Outdated Show resolved Hide resolved
khl/channel.py Outdated Show resolved Hide resolved
sileence114
sileence114 commented Mar 7, 2024
View reviewed changes
khl/channel.py Outdated Show resolved Hide resolved
@sileence114 sileence114 requested a review from TWT233 March 7, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TWT233 TWT233 Awaiting requested review from TWT233

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sileence114 @TWT233