Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid request if timeUrl contains a query parameter #444

Open
jkmatila opened this issue Dec 2, 2019 · 1 comment
Open

Invalid request if timeUrl contains a query parameter #444

jkmatila opened this issue Dec 2, 2019 · 1 comment
Assignees
Labels

Comments

@jkmatila
Copy link

jkmatila commented Dec 2, 2019

EvaporateJS uses an invalid URL for fetching the time if the timeUrl already contains query parameters. It will just append the request time at the end of the URL separated by a ? even if
query parameters already exist. See here: evaporate.js:152.

Steps to reproduce:

Set timeUrl to http://example.com/time?anotherparam=foo

Expected:

EvaporateJS should get http://example.com/time?anotherparam=foo&requestTime=...

Observed:

EvaporateJS gets http://example.com/time?anotherparam=foo?requestTime=...

@jakubzitny
Copy link
Collaborator

Yeah this looks incorrect, PR with a fix would be very appreciated 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants