Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre processing each upload part before upload #440

Open
ElPincheTopo opened this issue Sep 5, 2019 · 1 comment
Open

Pre processing each upload part before upload #440

ElPincheTopo opened this issue Sep 5, 2019 · 1 comment

Comments

@ElPincheTopo
Copy link
Contributor

I want to encrypt my files before uploading them to S3 and to avoid having to wait for the whole file to be encrypted first I want to encrypt each chunk of data before it gets uploaded.

I'm thinking about modifying Evaporate to do this while reading slicing the ArrayBuffer, maybe adding a pre-upload processing step that could also be used for other things.

Before doing any changes I would like to know if you could give me any feedback on what would be the best place to do this, and if there is a way in which this changes could be made in a generic enough way that could be useful for other use cases. I would prefer to contribute to the project and have my changes merged back into this repo than maintaining my own with my minor tweaks.

Thanks

@jakubzitny
Copy link
Collaborator

Hi @ElPincheTopo, thanks for proposing this. I would say it's a good idea and yes, doing it while slicing the ArrayBuffer makes sense. However, the codebase here is quite difficult to modify and update and I'd say the best time for implementing something like this would be after refactoring the whole codebase (let's call if v3) where all parts would be properly split and implemented in a way that's easily extendable.

If you decide to implement it in the current "one-file" codebase, I support you and I'll try to test it as well so we can merge it in the future. But I won't have the capacity to figure out the implementation details. Also, if you'll be doing that, extracting parts of the main file to separate files and adding a bundler could be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants