You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey guys, i noticed in the activate_single_plugin function if a plugin requires update, this function will still return true even if the plugin hasn't been activated.
Shouldn't this function return false if the plugin hasn't been activated, due to any reason? I would suggest return false in the $this->does_plugin_require_update( $slug ) condition check.
The text was updated successfully, but these errors were encountered:
hogash
changed the title
Activate
Activate single plugin returns true even though plugin hasn't been activated
Sep 9, 2019
Hey guys, i noticed in the
activate_single_plugin
function if a plugin requires update, this function will still returntrue
even if the plugin hasn't been activated.Shouldn't this function return false if the plugin hasn't been activated, due to any reason? I would suggest
return false
in the$this->does_plugin_require_update( $slug )
condition check.The text was updated successfully, but these errors were encountered: