Star Trek 25th Anniversary: Misaligned Border

[alyosha-tas]

The border in the intro text screen is misaligned. You can see it in this video for example, where it's zoomed in and really obvious:

https://www.youtube.com/watch?v=KsthKsr_2Sw&t=32s

You can also see it in this video, where it appears to be played on a gameboy player:

https://www.youtube.com/watch?v=HCmIQ24AMgo&t=62s

However, there are 2 videos where the border is properly aligned, one is played on SGB:

https://www.youtube.com/watch?v=bEArrvHV6wQ&t=181s

The other I'm not sure about:

https://www.youtube.com/watch?v=K-4r30hHwsA

The game uses the Window in a non-standard way. The top few scanlines are part of the window, then it turns off the window and the normal background is used for the text part, then turns the window back on for the bottom of the screen.

If the background is emulated normally, then it is in fact misaligned. If you look at the 2 videos with proper alignment, there is a clear blank vertical line on the left side of the screen. So, for some reason the background is being shifted to the right one pixel for the alignment to work out.

This one needs some console testing probably, since it could be it only works on original GB, or only on SGB, and maybe the behaviour was 'fixed' for CGB since the GBP video shows it misaligned again (if that is in fact real hardware.)

[nattthebear]

Might be useful to send this upstream to gambatte pokeymans

[alyosha-tas]

I have confirmed on my own GBP that the border is mis-aligned. So somewhere between original GB and GBP the behaviour changed. I made issues for this on both Sameboy and Gambatte Speedrun.

edit: LIJI32/SameBoy#278 and pokemon-speedrunning/gambatte-speedrun#58 --yoshi