Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceData.abi set as ContractInterface instead of ABI #158

Open
koredefashokun opened this issue Jan 28, 2022 · 1 comment
Open

SourceData.abi set as ContractInterface instead of ABI #158

koredefashokun opened this issue Jan 28, 2022 · 1 comment

Comments

@koredefashokun
Copy link

koredefashokun commented Jan 28, 2022 •
edited
Loading

In the declaration of the SourceData type here:

js-monorepo/packages/contracts-interface/src/synthetix.d.ts

Line 7 in d8b882a

abi: ethers.ContractInterface;

The abi field is set as a ethers.ContractInterface, but the code from the synthetix package actually returns a regular ABI.
@koredefashokun koredefashokun changed the title SourceRecord.abi set as ContractInterface instead of ABI SourceData.abi set as ContractInterface instead of ABI Jan 28, 2022
@fritzschoff
Copy link
Contributor

Hey, what do you mean by regular ABI? Just an array?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koredefashokun @fritzschoff