Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook examples outdated #10

Open
jgradzki opened this issue Aug 26, 2021 · 2 comments
Open

Storybook examples outdated #10

jgradzki opened this issue Aug 26, 2021 · 2 comments

Comments

@jgradzki
Copy link

Hi,

I noticed that some examples(stories) in storybook seems outdated.

For example:

<Layout
left={<S.Placeholder></S.Placeholder>}
right={<S.Placeholder></S.Placeholder>}
transitionName={transitionName}
transitionTime={transitionTime}
>

transitionName and transitionTime props are passed to Layout component but in current Layout props definition there are no such properties:

export type LayoutProps = {
header?: React.ReactNode;
subheader?: React.ReactNode;
left?: React.ReactNode;
right?: React.ReactNode;
children: React.ReactNode;
className?: string;
styles?: Style<React.CSSProperties>;
leftOpened?: boolean;
rightOpened?: boolean;
fullPage?: boolean;
};

Are there any plans to update docs?

@rootsher
Copy link

@ofsajd ☝️

@ccrvlh
Copy link

ccrvlh commented Jan 29, 2022

Same for appLayout and CardSelectGroup (no column prop). Any visibility on if/when the source code will be up to date with the storybook?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants