Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use STIR's sum(), find_max(), operator+= etc #1259

Open
KrisThielemans opened this issue May 29, 2024 · 1 comment
Open

use STIR's sum(), find_max(), operator+= etc #1259

KrisThielemans opened this issue May 29, 2024 · 1 comment
Assignees

Comments

@KrisThielemans
Copy link
Member

We currently implement our own max() functions etc.

STIRImageData::max(void* ptr) const
{
#if defined(_MSC_VER) && _MSC_VER < 1900
Image3DF::const_full_iterator iter;

However, STIR has equivalents (e.g. find_max() and will soon optimise these. It would therefore be better to call them instead.

This could maybe be done by moving some of the generic implementations to DataContainer, and overriding for the STIR data containers, although that might be more complicated.

@evgueni-ovtchinnikov
Copy link
Contributor

Do we really need operator+= etc. in C++ (already have in Python)? If not, then we are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants