Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test PET__PYTHON_ALGEBRA is very slow #1013

Closed
KrisThielemans opened this issue Oct 18, 2021 · 5 comments · May be fixed by #1027
Closed

test PET__PYTHON_ALGEBRA is very slow #1013

KrisThielemans opened this issue Oct 18, 2021 · 5 comments · May be fixed by #1027

Comments

@KrisThielemans
Copy link
Member

It takes 120s on my machine. Would be worth finding out which bit is so slow (or is it everything?)

@evgueni-ovtchinnikov
Copy link
Contributor

@KrisThielemans out of 39 unit tests, 26 work with two AcquisitionData objects (stored in file in 13 tests) currently of size 357 x 126 x 344 = 15 473 808 - with my_forward_projection.hs it takes 20 sec on my laptop

@KrisThielemans
Copy link
Member Author

I guess the AcquisitionData tests still take a lot of time (hopefully only the InFile ones). It certainly makes sense to do it with smaller data, as it's just a waste of resources otherwise.

@evgueni-ovtchinnikov
Copy link
Contributor

PET AcquisitionData can be created from the scanner name - is it possible to create a small enough one for testing? My guess is that max_ring_diff can help - what about span and view_mash_factor?

@paskino
Copy link
Contributor

paskino commented Oct 23, 2021

To change to smaller dataset it is sufficient to replace the self.image1 and self.image2 in all the test classes.

https://github.com/SyneRBI/SIRF/blob/master/src/xSTIR/pSTIR/tests/test_algebra.py

When I created the tests I just used some ImageData and AcquisitionData that was in the data directory. Clearly this is sub-optimal.

@evgueni-ovtchinnikov
Copy link
Contributor

@KrisThielemans now takes 6 sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants