We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShopApiPlugin/src/Handler/Cart/AssignCustomerToCartHandler.php
Line 42 in 3ace127
AssignCustomerToCartHandler uses ShopUserAwareCustomerProvider, which uses loggedInShopUserProvider.
AssignCustomerToCartHandler
ShopUserAwareCustomerProvider
loggedInShopUserProvider
That makes AssignCustomerToCartHandler stateful by depending to currently logged in user.
I think this is not optimal and should be avoided the same way as channel/locale/currency contexts are not used in handlers directly.
The text was updated successfully, but these errors were encountered:
Yeah you are right. This should be a part of the command itself.
Sorry, something went wrong.
No branches or pull requests
ShopApiPlugin/src/Handler/Cart/AssignCustomerToCartHandler.php
Line 42 in 3ace127
AssignCustomerToCartHandler
usesShopUserAwareCustomerProvider
, which usesloggedInShopUserProvider
.That makes
AssignCustomerToCartHandler
stateful by depending to currently logged in user.I think this is not optimal and should be avoided the same way as channel/locale/currency contexts are not used in handlers directly.
The text was updated successfully, but these errors were encountered: