Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support for subTotal - added in Sylius 1.6 #595

Open
AndreasA opened this issue Nov 6, 2019 · 3 comments
Open

[FEATURE] Support for subTotal - added in Sylius 1.6 #595

AndreasA opened this issue Nov 6, 2019 · 3 comments

Comments

@AndreasA
Copy link

AndreasA commented Nov 6, 2019

With Sylius 1.6 they added better support regarding taxes and subtotal. The itemsTotal always includes taxes. Now the summary contains the items total (with tax) - if strategy is set accordingly - or without tax the sub total. This was added with https://github.com/Sylius/Sylius/pull/10400/files

@AndreasA
Copy link
Author

AndreasA commented Nov 6, 2019

In general you need various improvements regarding this as e.g. shipping charges by default include the tax in Sylius (always). However, the tax total also includes the tax of the shipping charges, so any subtotal one might calculate manually will always be wrong.

@mamazu
Copy link
Member

mamazu commented Nov 6, 2019

Yes, that is true. The totals object is quite confusing.

@AndreasA
Copy link
Author

I also think it is a bit confusing how Sylius itself handles it in their entities. Having one method that returns the value with and one without taxes would make it way easier to get the desired values for the webshop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants