Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide factories for Invoice and LineItem #182

Open
mvriel opened this issue Aug 13, 2020 · 0 comments
Open

Provide factories for Invoice and LineItem #182

mvriel opened this issue Aug 13, 2020 · 0 comments

Comments

@mvriel
Copy link

mvriel commented Aug 13, 2020

In our application, we have extended the line item to include an extra field that we want to show on the PDF. But because LineItem does not have a factory class (like most other parts do) I had to duplicate the LineItemConverter.

This may cause issues in the future when Sylius decides to change this part of the application and it would have been more durable if there was a factory that I could decorate so that I can very specifically update the LineItem in that factory (by decorating it) and then leaving the converters alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant