Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't MessageHandlers be configured to only process messages from this plugin's message buses ? #157

Open
acornforth opened this issue Sep 27, 2019 · 1 comment

Comments

@acornforth
Copy link

acornforth commented Sep 27, 2019

I am developing a plugin for sylius, and, as with this plugin, I am using messenger.

When debugging my code with php bin/console debug:messenger I can see that this plugins message handlers are listening to all buses.

While this is not an urgent issue, and may not even produce any errors in most cases, surely, for maximum interoperability with other plugins/bundles, unless there is a specific reason why these handlers need to listen on other buses, they should probably be restricted to the buses defined in this bundle.

Mainly I'm asking in order to validate whether i need to do this in my own bundle...

@acornforth acornforth changed the title Shouldn't _this plugin's_ MessageHandlers be configured to only process messages from _this plugin's_ message buses ? Shouldn't MessageHandlers be configured to only process messages from this plugin's message buses ? Sep 27, 2019
@acornforth
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant