Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROP UNIQ_16C8119E5CDB2AEB and billing_data_id taxId sql will be generated when I run do:sc:up --dump-sql #150

Open
tom10271 opened this issue Jul 25, 2019 · 2 comments

Comments

@tom10271
Copy link
Contributor

tom10271 commented Jul 25, 2019

     ALTER TABLE sylius_invoicing_plugin_invoice CHANGE channel_code channel_code VARCHAR(255) NOT NULL, CHANGE channel_name channel_name VARCHAR(255) NOT NULL;
     DROP INDEX UNIQ_16C8119E5CDB2AEB ON sylius_channel;
     ALTER TABLE sylius_channel DROP billing_data_id, DROP taxId;

Are some of the migration script missing?

I am using sylius/invoicing-plugin:0.8.3

@peterukena
Copy link

Generate your own migration - remove all migrations from the plugin and diff your own one. Some migrations are missing and some in this plugin are just wrong. Sadly.

@diimpp
Copy link
Member

diimpp commented Feb 19, 2021

Just did a fresh installation on sylius 1.8 and invoicing plugin 0.12.0 -- everything alright migration vise, no stray SQLs in --dump-sql

Since doctrine-migrations:3 and that plugin migrations available directly in the app, advise to skip plugin migrations will be problematic in long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants