You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context
Command palette support was added in #14#102.
There are a few minor shortcomings with it, though:
The tooltip text says, "Open command palette (CMD+k)".
Although the text says 'CMD', the code actually uses [Meta Key] + k, where Meta Key is CMD on mac or WINDOWS KEY on windows. Without knowing that, however, Windows users might suspect that the command palette only works for mac users.
The cmd palette wasn't tested on Windows
I'm on Mac and have never tested that the command palette works on Windows.
Tasks
Update tooltip text so that it shows "{Cmd} + k" for mac users and "{Win} + k" for windows users*, where {Cmd} and {Win} refer to the icons
If you're a Windows user:
Test it works on Windows and post a comment here to confirm
Context
Command palette support was added in #14 #102.
There are a few minor shortcomings with it, though:
Although the text says 'CMD', the code actually uses [Meta Key] + k, where Meta Key is CMD on mac or WINDOWS KEY on windows. Without knowing that, however, Windows users might suspect that the command palette only works for mac users.
I'm on Mac and have never tested that the command palette works on Windows.
Tasks
If you're a Windows user:
Implementation Guidance
Update
MetaKey.tsx
See
icon
prop in thereact-cmdk ListItem API
The text was updated successfully, but these errors were encountered: