Replies: 6 comments
-
Attaching screenshot - the orange here was viewed as "red". |
Beta Was this translation helpful? Give feedback.
-
(and codecov also uses orange as warning color due to not enough test coverage) |
Beta Was this translation helpful? Give feedback.
-
So the rationale for change would be that most people expect badges to signal how the health of some part of the CI pipeline is, while the SPI one is using the Swift logo color. |
Beta Was this translation helpful? Give feedback.
-
I can see how people would think this, however I'd want to be cautious using green for this badge. You already mentioned that people see these as “most people expect badges to signal how the health of some part of the CI pipeline is” and we are very much not trying to be CI for every open-source Swift package. If we change this colour, we should move to a blue or grey or other less “loaded” colour that shows information rather than being seen as indicating passing/failing. |
Beta Was this translation helpful? Give feedback.
-
That makes a lot of sense, agree - some neutral color would be great. |
Beta Was this translation helpful? Give feedback.
-
Tracked as #3411 |
Beta Was this translation helpful? Give feedback.
-
I got a comment on the colouring of the badges that is generated from SPI for the Benchmark package - basically it was thought it was an error/warning colour and that there was a problem (see ordo-one/package-benchmark#205 (comment)) .
Maybe it is worth using the Swift logo color to the left of the badge as is, but have some green color for "ok" for the supported compiler versions/os versions, as it is a positive things that those are supported (and now it was construed as that there was a problem with the CI pipeline for those versions...).
Beta Was this translation helpful? Give feedback.
All reactions