Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Idp provider list sign out Issue #1461

Open
AnisAli opened this issue Jul 24, 2024 · 1 comment
Open

Dynamic Idp provider list sign out Issue #1461

AnisAli opened this issue Jul 24, 2024 · 1 comment

Comments

@AnisAli
Copy link

AnisAli commented Jul 24, 2024

In my project, I use the SustainSys library to allow companies to set up their SSO IDP. Since we don't have a predefined list of providers when configuring Saml2, we inject dynamic IdPs using the GetIdentityProvider and SelectIdentityProvider notifications. These notifications are handy for executing login commands. However, the main issue arises during the InitiateLogout command because the InitiateLogout command does not use notifications to fetch the IdP. Instead, it uses the following code.

File: https://github.com/Sustainsys/Saml2/blob/v2/Sustainsys.Saml2/WebSSO/LogOutCommand.cs
var knownIdp = options.IdentityProviders.TryGetValue(new EntityId(idpEntityId), out IdentityProvider idp);

It would be helpful to support fetching the IDP using notifications, instead of relying solely on a predefined list of providers. Alternatively, please suggest a solution to accommodate dynamic IDP providers.

@AndersAbel
Copy link
Member

This is a clearly a missing feature - the dynamic support doesn't work with logout.

@AndersAbel AndersAbel removed the triage label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants