Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to add User-Agent header for metadata HTTP request #1450

Open
martintro opened this issue Apr 15, 2024 · 4 comments
Open

Configuration to add User-Agent header for metadata HTTP request #1450

martintro opened this issue Apr 15, 2024 · 4 comments

Comments

@martintro
Copy link

We have a customer that blocks HTTP requests that are missing the User-Agent header. Seems like this product from Microsoft has something like that builtin https://learn.microsoft.com/en-us/azure/web-application-firewall/ag/ag-overview#features.

Because of this HTTP requests to load IDP metadata is blocked/timed out.

Can we add configuration to be able to add the User-Agent header to the IDP metadata HTTP request? I can help with PR if you want.

Thanks in advance!

@martintro martintro changed the title Add configuration to add User-Agent header for metadata HTTP request Configuration to add User-Agent header for metadata HTTP request Apr 15, 2024
@AndersAbel
Copy link
Member

This looks like a reasonable request so I'm marking it as a possible future feature. I try to use the (limited) time I have on working on the library on critical bug fixes and development of the v3 version. This is something I would be happy to consider for v3, but for v1 or v2 I really only do security releases (unless there's from a paying customer, please reach out to [email protected] if you want to know more about available options).

@martintro
Copy link
Author

Could it be an option that I do a pull request with the feature and then you release it in v2? What is the time frame for v3?

@AndersAbel
Copy link
Member

The time frame for v3 is still a best-effort, I cannot make any commitments as long as I'm spending my own spare time to work on it.

I only merge PRs to V2 for paying customers. Even if you write the PR, there's still work to do with reviews and creating the actual release. If you want to get anything into V2 or to speed things up with V3, please reach out to discuss commercial options.

@martintro
Copy link
Author

Alright. We'll see if it is an option to pay for it. Otherwise we wait and hope for V3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants