xoutSetup LogOnlyXout, CoutOnlyXout should not ignore setupLogging, setupCout parameters

[N-Dekker]

Please check elxElastixMain.cxx commit 763327c

elastix/src/Core/Kernel/elxElastixMain.cxx

Lines 66 to 89 in 763327c

	if( setupLogging )
	{
	/** Open the logfile for writing. */
	g_LogFileStream.open( logfilename );
	if ( !g_LogFileStream.is_open() )
	{
	std::cerr << "ERROR: LogFile cannot be opened!" << std::endl;
	return 1;
	}
	}
	/** Set std::cout and the logfile as outputs of xout. */
	if( setupLogging )
	{
	returndummy |= xout.AddOutput("log", &g_LogFileStream);
	}
	if( setupCout )
	{
	returndummy |= xout.AddOutput("cout", &std::cout);
	}
	/** Set outputs of LogOnly and CoutOnly. */
	returndummy |= g_LogOnlyXout.AddOutput( "log", &g_LogFileStream );
	returndummy |= g_CoutOnlyXout.AddOutput( "cout", &std::cout );

It seems to me that the following two statements should be surrounded by if( setupLogging ) and if( setupCout ), respectively. Right?

returndummy |= g_LogOnlyXout.AddOutput( "log", &g_LogFileStream );
returndummy |= g_CoutOnlyXout.AddOutput( "cout", &std::cout );

The main question is: Do we want no console output at all from the logger, when the ITKElastix/SimpleITK elastix library property LogToConsole = false? Or do we still want logging directed to "coutonly" to appear on the console anyway?