Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macos-14 in CI #1105

Open
thewtex opened this issue Apr 21, 2024 · 3 comments
Open

Add macos-14 in CI #1105

thewtex opened this issue Apr 21, 2024 · 3 comments

Comments

@thewtex
Copy link
Contributor

thewtex commented Apr 21, 2024 •
edited
Loading

This is an ARM architecture mac system aka Apple Silicon.

This will add more compiler checks. In InsightSoftwareConsortium/ITKElastix#278 we also observe numerical differences at the application level -- the test suite might provide more insights.
N-Dekker added a commit that referenced this issue Apr 24, 2024
@N-Dekker
ENH: Upgrade GitHub Actions CI from macos-12 to macos-14
45dcc66 
Triggered by issue #1105 "Add macos-14 in CI" submitted by Matt McCormick, as well as a remark by Bradley Lowekamp at SimpleITK/SimpleITK#2104 (comment)
N-Dekker added a commit that referenced this issue Apr 26, 2024
@N-Dekker
ENH: Upgrade GitHub Actions CI from macos-12 to macos-14
61ac199 
Triggered by issue #1105 "Add macos-14 in CI" submitted by Matt McCormick, as well as a remark by Bradley Lowekamp at SimpleITK/SimpleITK#2104 (comment)
N-Dekker added a commit that referenced this issue Apr 26, 2024
@N-Dekker
ENH: Upgrade Azure Pipelines CI from macos-11 to macos-14
395a2a4 
Triggered by issue #1105 "Add macos-14 in CI" submitted by Matt McCormick, as well as a remark by Bradley Lowekamp at SimpleITK/SimpleITK#2104 (comment)

macos-11 is no longer maintained anyway. It is now deprecated, according to https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml
@N-Dekker
Copy link
Member

@thewtex Thanks for the suggestion, but all I got so far from upgrading to macos-14 (branch https://github.com/SuperElastix/elastix/tree/GitHubActions-macos-14) are extra warnings, at https://my.cdash.org/viewBuildError.php?type=1&buildid=2550398 saying:

ld: warning: ignoring duplicate libraries: '-lm', '/.../ITK-build/lib/libITKCommon-5.4.a', ...

🤷

@thewtex
Copy link
Contributor Author

thewtex commented May 7, 2024

@N-Dekker I addressed these warnings in ITK via InsightSoftwareConsortium/ITK@7231bf7 -- bumping ITK should do the trick!

@N-Dekker
Copy link
Member

N-Dekker commented May 7, 2024 •
edited
Loading

Now trying to upgrade: https://github.com/SuperElastix/elastix/tree/Upgrade-ITK-to-v5.4rc04

N-Dekker added a commit that referenced this issue May 7, 2024
@N-Dekker
ENH: Upgrade GitHub Actions CI from macos-12 to macos-14
3676d18 
Triggered by issue #1105 "Add macos-14 in CI" submitted by Matt McCormick, as well as a remark by Bradley Lowekamp at SimpleITK/SimpleITK#2104 (comment)
N-Dekker added a commit that referenced this issue May 7, 2024
@N-Dekker
ENH: Upgrade Azure Pipelines CI from macos-11 to macos-14
b85588c 
Triggered by issue #1105 "Add macos-14 in CI" submitted by Matt McCormick, as well as a remark by Bradley Lowekamp at SimpleITK/SimpleITK#2104 (comment)

macos-11 is no longer maintained anyway. It is now deprecated, according to https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thewtex @N-Dekker