Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require improvement in pre dyFinance_exp.sol #672

Open
AlexMercer00 opened this issue May 21, 2024 · 2 comments
Open

Require improvement in pre dyFinance_exp.sol #672

AlexMercer00 opened this issue May 21, 2024 · 2 comments

Comments

@AlexMercer00
Copy link

Hi, @owner

I wanted to bring to your attention some issues that were identified in the PredyFinance_exp.sol contract file . These issues pose potential security risks and could lead to vulnerabilities if left unaddressed.

   Issue: Unauthorized access to critical functions.
  • Solution: Implement onlyOwner or similar access control modifiers.

    Isue: Unauthorized withdrawals of assets.
    
  • Solution: Introduce authorization checks in withdrawal functions.

    Issue:  Bypassing safety checks in `take` and `supply` functions.
    
  • Solution: Enhance validation and access control in asset management functions.

    Issue: Lack of validation in `predyTradeAfterCallback`.
    
  • Solution: Add necessary checks and restrict access to callback functions.

     Issue: Use of insecure and hardcoded price data.
    
  • Solution: Use reliable oracle-based price feeds.

It's essential to address these issues promptly to ensure the security and integrity of the PredyFinance contract.
Thank you for your attention to this matter, and I look forward to working together to improve the security of the PredyFinance contract.

@SaulRojas1505
Copy link

Issue: Unauthorized access to critical functions.

@SaulRojas1505
Copy link

/

Hi, @owner

I wanted to bring to your attention some issues that were identified in the PredyFinance_exp.sol contract file . These issues pose potential security risks and could lead to vulnerabilities if left unaddressed.

   Issue: Unauthorized access to critical functions.
  • Solution: Implement onlyOwner or similar access control modifiers.
    Isue: Unauthorized withdrawals of assets.
    
  • Solution: Introduce authorization checks in withdrawal functions.
    Issue:  Bypassing safety checks in `take` and `supply` functions.
    
  • Solution: Enhance validation and access control in asset management functions.
    Issue: Lack of validation in `predyTradeAfterCallback`.
    
  • Solution: Add necessary checks and restrict access to callback functions.
     Issue: Use of insecure and hardcoded price data.
    
  • Solution: Use reliable oracle-based price feeds.

It's essential to address these issues promptly to ensure the security and integrity of the PredyFinance contract. Thank you for your attention to this matter, and I look forward to working together to improve the security of the PredyFinance contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants