Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI #50

Closed
Sudha247 opened this issue Oct 17, 2023 · 9 comments
Closed

Set up CI #50

Sudha247 opened this issue Oct 17, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Sudha247
Copy link
Owner

To prevent build failures like the ones mentioned in #47, a CI will be useful. We can use GitHub actions and setup-ocaml for setting up the CI. Here's an example - https://github.com/ocaml-multicore/domainslib/blob/main/.github/workflows/main.yml.

@Sudha247 Sudha247 added enhancement New feature or request good first issue Good for newcomers labels Oct 17, 2023
@TitilayoAdeyemi
Copy link
Contributor

TitilayoAdeyemi commented Oct 17, 2023

Hi @Sudha247 Would be glad to work on this task. Can you assign it to me?

@Sudha247
Copy link
Owner Author

Sure, please go ahead.

@TitilayoAdeyemi
Copy link
Contributor

Thanks @Sudha247 I'd be on it

@TitilayoAdeyemi
Copy link
Contributor

Hello @Sudha247 I have created a PR for this. Kindly review, I'd be expecting feedback. Thanks

@nangahamandine
Copy link
Contributor

Great job @TitilayoAdeyemi! :)
Thank you so much for your amazing contribution. Through this, I got to learn more about continuous integration.

I've done a little refactore of the CI in my present PRs so all the checks are passed now with no issues.

@Sudha247
Copy link
Owner Author

@nangahamandine I noticed the CI failures due to dependencies on windows, too. Can you submit a separate PR for fixing it so we can review and merge it quickly, please?

@nangahamandine
Copy link
Contributor

@nangahamandine I noticed the CI failures due to dependencies on windows, too. Can you submit a separate PR for fixing it so we can review and merge it quickly, please?

Okay, sure. I'll do that now.

@nangahamandine
Copy link
Contributor

I've opened a PR for the refactor at PR #70
Please review.

@Sudha247
Copy link
Owner Author

Fixed by #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants