Improve linux support (new launcher) #1848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Measurity
force-pushed
the
linux
branch
2 times, most recently
from
cfb2938 to
dc11b8b
Compare
Measurity
added
Area: user interface (launcher)
Measurity
force-pushed
the
linux
branch
2 times, most recently
from
49cf07d to
bbfcd47
Compare
Closed
2 tasks
|
With that, we present to you the Cross-Platform launcher. Have fun reviewing this 🌚 |
|
:soonTM: |
This reduces complexity of loading logic
This removes need of some lines in code behind of main window.
Send icon was black but should be white. Send icon was too large but should be 20x20.
The embedded server view crash happened when you send an empty command
Co-Authored-By: Meas <[email protected]>
For some reason, the ViewBox won't change its height with the itemsControl.
dartasen
reviewed
Dec 22, 2024
|
|
||
| private static string GetIconPathForPlatform(Platform? platform) => platform switch | ||
| { | ||
| Platform.EPIC => "/Assets/Images/store-icons/epic.png", |
There was a problem hiding this comment.
Should we leave hardcoded path like that, or create a static class that would aggregate them ?
There was a problem hiding this comment.
True it's not ideal. I think we should change it to how .notifications style is done in MainWindow.axaml which uses conditional classes to select the icon we want.
Nitrox.Launcher/Models/Converters/DateToRelativeDateConverter.cs
Outdated
Show resolved
Hide resolved
Added command line parsing to launcher Fixed some review comments from Clement Fixed a bunch of minor things
Now also used in Program.cs for crash reporting
After2 hours of debugging, Measurity and I finally figured it out lol. It was mostly all Meas Co-Authored-By: Meas <[email protected]>
Used ProjectReference instead of build targets which allows MSBuild to reuse build cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet buildon dotnet SDK 8+NitroxLauncherto play Subnautica with Nitrox.NitroxLauncher)This PR includes solution-wide changes to multi-target for .net 9 (server, launcher) and .net 4.7.2 (game client), allowing benefits of modern .net where possible.
Closes #988
Resources to assist with implementation