From 0304f3f5efce37b663f8945b9963d3a6b4c70a03 Mon Sep 17 00:00:00 2001 From: TRTomasz Date: Fri, 6 Dec 2024 10:25:42 +0100 Subject: [PATCH] fix: change default send crash reports value to true --- src/runtime/env.rs | 4 ++-- src/types/profile/settings.rs | 2 +- src/unit_tests/serde/default_tokens_ext.rs | 2 +- src/unit_tests/serde/settings.rs | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/runtime/env.rs b/src/runtime/env.rs index 5c84d78ce..bfff5af03 100644 --- a/src/runtime/env.rs +++ b/src/runtime/env.rs @@ -628,7 +628,7 @@ fn migrate_storage_schema_to_v16() -> TryEnvFuture<()> { ); settings.insert( "sendCrashReports".to_owned(), - serde_json::Value::Bool(false), + serde_json::Value::Bool(true), ); E::set_storage(PROFILE_STORAGE_KEY, Some(&profile)) } @@ -1196,7 +1196,7 @@ mod test { let migrated_profile = json!({ "settings": { "serverInForeground": false, - "sendCrashReports": false + "sendCrashReports": true } }); diff --git a/src/types/profile/settings.rs b/src/types/profile/settings.rs index 6446331bd..bea632b38 100644 --- a/src/types/profile/settings.rs +++ b/src/types/profile/settings.rs @@ -80,7 +80,7 @@ impl Default for Settings { surround_sound: false, streaming_server_warning_dismissed: None, server_in_foreground: false, - send_crash_reports: false, + send_crash_reports: true, } } } diff --git a/src/unit_tests/serde/default_tokens_ext.rs b/src/unit_tests/serde/default_tokens_ext.rs index 4174593c0..6a53cd98d 100644 --- a/src/unit_tests/serde/default_tokens_ext.rs +++ b/src/unit_tests/serde/default_tokens_ext.rs @@ -438,7 +438,7 @@ impl DefaultTokens for Settings { Token::Str("serverInForeground"), Token::Bool(false), Token::Str("sendCrashReports"), - Token::Bool(false), + Token::Bool(true), Token::StructEnd, ] } diff --git a/src/unit_tests/serde/settings.rs b/src/unit_tests/serde/settings.rs index 6e12cf648..72932d29e 100644 --- a/src/unit_tests/serde/settings.rs +++ b/src/unit_tests/serde/settings.rs @@ -37,7 +37,7 @@ fn settings() { Utc.with_ymd_and_hms(2021, 1, 1, 0, 0, 0).unwrap(), ), server_in_foreground: false, - send_crash_reports: false, + send_crash_reports: true, }, &[ Token::Struct { @@ -110,7 +110,7 @@ fn settings() { Token::Str("serverInForeground"), Token::Bool(false), Token::Str("sendCrashReports"), - Token::Bool(false), + Token::Bool(true), Token::StructEnd, ], ); @@ -183,7 +183,7 @@ fn settings_de() { Token::Str("serverInForeground"), Token::Bool(false), Token::Str("sendCrashReports"), - Token::Bool(false), + Token::Bool(true), Token::StructEnd, ], );