From cd18055d07628dbaeff0d7360dbf19b682af4882 Mon Sep 17 00:00:00 2001 From: Michael Patsula Date: Tue, 16 Jul 2024 13:11:48 -0400 Subject: [PATCH 1/4] feat(argo-controller): parameterize argo workflows role bindings & clsuter role names --- stable/argo-controller/Chart.yaml | 2 +- stable/argo-controller/templates/deployment-workflows.yaml | 3 +++ stable/argo-controller/values.yaml | 6 ++++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/stable/argo-controller/Chart.yaml b/stable/argo-controller/Chart.yaml index d0528afb..c6bdf515 100644 --- a/stable/argo-controller/Chart.yaml +++ b/stable/argo-controller/Chart.yaml @@ -15,7 +15,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.0.7 +version: 0.0.8 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to diff --git a/stable/argo-controller/templates/deployment-workflows.yaml b/stable/argo-controller/templates/deployment-workflows.yaml index 67a5af50..e4fcc92f 100644 --- a/stable/argo-controller/templates/deployment-workflows.yaml +++ b/stable/argo-controller/templates/deployment-workflows.yaml @@ -36,6 +36,9 @@ spec: imagePullPolicy: {{ .Values.image.pullPolicy }} args: - workflows + - -- namespace-admins-role-binding-name={{ required "workflows.args.namespaceAdminsRoleBindingName is required" .Values.workflows.args.namespaceAdminsRoleBindingName }} + - -- user-interface-cluster-role-name={{ required "workflows.args.userInterfaceClusterRoleName is required" .Values.workflows.args.userInterfaceClusterRoleName }} + - -- argo-workflows-cluster-role-name={{ required "workflows.args.argoWorkflowsClusterRoleName is required" .Values.workflows.args.argoWorkflowsClusterRoleName }} env: {{- if .Values.storageAccount.existingSecret }} - name: ARGO_SECRET_NAME diff --git a/stable/argo-controller/values.yaml b/stable/argo-controller/values.yaml index 92a2c188..e0de6d24 100644 --- a/stable/argo-controller/values.yaml +++ b/stable/argo-controller/values.yaml @@ -59,3 +59,9 @@ serviceAccount: # The name of the service account to use. # If not set and create is true, a name is generated using the fullname template name: "" + +workflows: + args: + namespaceAdminsRoleBindingName: "solution-builder" + userInterfaceClusterRoleName: + argoWorkflowsClusterRoleName: \ No newline at end of file From bd178484804888b0c127674ab270da6fcea0f756 Mon Sep 17 00:00:00 2001 From: Michael Patsula Date: Tue, 16 Jul 2024 13:20:30 -0400 Subject: [PATCH 2/4] style: add extra line at bottom of file --- stable/argo-controller/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stable/argo-controller/values.yaml b/stable/argo-controller/values.yaml index e0de6d24..d977826d 100644 --- a/stable/argo-controller/values.yaml +++ b/stable/argo-controller/values.yaml @@ -64,4 +64,4 @@ workflows: args: namespaceAdminsRoleBindingName: "solution-builder" userInterfaceClusterRoleName: - argoWorkflowsClusterRoleName: \ No newline at end of file + argoWorkflowsClusterRoleName: From b257c8cac4b5eb42c5b8441ac2740487c8495516 Mon Sep 17 00:00:00 2001 From: Michael Patsula Date: Tue, 16 Jul 2024 13:21:06 -0400 Subject: [PATCH 3/4] feat: update appVersion --- stable/argo-controller/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stable/argo-controller/Chart.yaml b/stable/argo-controller/Chart.yaml index c6bdf515..023e125c 100644 --- a/stable/argo-controller/Chart.yaml +++ b/stable/argo-controller/Chart.yaml @@ -21,4 +21,4 @@ version: 0.0.8 # incremented each time you make changes to the application. Versions are not expected to # follow Semantic Versioning. They should reflect the version the application is using. # It is recommended to use it with quotes. -appVersion: "0.0.1" +appVersion: "0.0.2" From e9132a3b6ddeb93b6111c1435398d44900db3d09 Mon Sep 17 00:00:00 2001 From: Michael Patsula Date: Thu, 18 Jul 2024 13:06:31 -0400 Subject: [PATCH 4/4] feat: remove default value for namespaceAdminsRoleBindingName --- stable/argo-controller/Chart.yaml | 2 +- stable/argo-controller/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/stable/argo-controller/Chart.yaml b/stable/argo-controller/Chart.yaml index 3ad0ffe7..c994f6ae 100644 --- a/stable/argo-controller/Chart.yaml +++ b/stable/argo-controller/Chart.yaml @@ -21,4 +21,4 @@ version: 0.0.11 # incremented each time you make changes to the application. Versions are not expected to # follow Semantic Versioning. They should reflect the version the application is using. # It is recommended to use it with quotes. -appVersion: "0.0.2" +appVersion: "0.0.1" diff --git a/stable/argo-controller/values.yaml b/stable/argo-controller/values.yaml index 75864038..667abc03 100644 --- a/stable/argo-controller/values.yaml +++ b/stable/argo-controller/values.yaml @@ -65,6 +65,6 @@ serviceAccount: workflows: args: - namespaceAdminsRoleBindingName: "solution-builder" + namespaceAdminsRoleBindingName: userInterfaceClusterRoleName: argoWorkflowsClusterRoleName: