Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type annotations in \AbraFlexi\Exception class #52

Open
jaroslavlibal opened this issue Nov 19, 2024 · 0 comments
Open

Incorrect type annotations in \AbraFlexi\Exception class #52

jaroslavlibal opened this issue Nov 19, 2024 · 0 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers invalid This doesn't seem right

Comments

@jaroslavlibal
Copy link

Hello,

the $errorMessages property tn the \AbraFlexi\Exception class has an incorrect array<string> annotation, so do the getErrorMessages() and getErrorMessage() methods.

The getErrorMessages() method returns array of arrays like var_dumped below:

array(1) {
  [0]=>
  array(1) {
    ["message"]=>
    string(105) "Adresa https://server/c/company-name/faktura-vydana/xxx není platná."
  }
}

Introduced here: 23a0e12#diff-6c213693e8ea3922558d3fe889351f27b5054c289a507fa15289c29d56e53285R30

@Vitexus Vitexus self-assigned this Nov 19, 2024
@Vitexus Vitexus added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers invalid This doesn't seem right labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants