Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a stare-config executable #93

Open
NiklasPhabian opened this issue Aug 27, 2021 · 2 comments
Open

add a stare-config executable #93

NiklasPhabian opened this issue Aug 27, 2021 · 2 comments

Comments

@NiklasPhabian
Copy link
Member

It might be worthwhile to mimic e.g. geos' approach to provide an executable supplying us with info about the installed version of the library. This becomes increasingly necessary to keep STARE and pystare in sync for users (SpatioTemporal/pystare#60)

Usage: geos-config [OPTIONS]
Options:
     [--prefix]
     [--version]
     [--libs]
     [--clibs]
     [--cclibs]
     [--static-clibs]
     [--static-cclibs]
     [--cflags]
     [--ldflags]
     [--includes]
     [--jtsport]

geos-config --version
3.8.0
@NiklasPhabian
Copy link
Member Author

NiklasPhabian commented Oct 6, 2021

@michaelleerilee what would be the right way to check what version of STARE is installed in the e.g. the "STARE_LIB_DIR" right now. Would we have to look at the VERSION file of the source or is there any way of getting the version out of the build?
Does my above mentioned approach make sense to you e.g. having an executable that installs with STARE that allows to do

$ stare-config --version
1.2.5

@NiklasPhabian
Copy link
Member Author

Extending on this; exposing hardcoded versions into the target wont be sufficient. We should much rather poll the version from the git tag or, failing that from the commit hash. In python, versioneer does just that for us. But there should be an equivalent for e.g. cmake.

Hardcoding version numbers will get us in trouble and hours of lost time in confusion when we work with on feature branches or even worse, forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant