Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ms precision in fromStringJulianTAI_ISO() #92

Open
NiklasPhabian opened this issue Aug 26, 2021 · 1 comment
Open

ms precision in fromStringJulianTAI_ISO() #92

NiklasPhabian opened this issue Aug 26, 2021 · 1 comment

Comments

@NiklasPhabian
Copy link
Member

in fromStringJulianTAI_ISO(), we hardcode the precision of milliseconds to 3.
Would it be possible to have them be variable length ... anything between the decimal separator . and the forward res (? .
This is really just about style. I just feel bad for quietly truncating.

TemporalIndex::fromStringJulianTAI_ISO(string inputString) {}

...
PARSE_INT(millisecond,3);
...
@michaelleerilee
Copy link
Collaborator

We could change the parsing to seek the end of the subsecond digits. And then quietly truncate to the number of digits actually encoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants