Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparkPost.Endpoint.decode_response_body/1 uses decoding as atoms #52

Open
begedin opened this issue Oct 12, 2020 · 0 comments
Open

SparkPost.Endpoint.decode_response_body/1 uses decoding as atoms #52

begedin opened this issue Oct 12, 2020 · 0 comments

Comments

@begedin
Copy link

begedin commented Oct 12, 2020

Creating this ticket so I can remove a TODO from code.

Poison.encode(keys: :atoms) is potentially unsafe for open ended structures such as metadata and substitution_data, as atoms are not garbage collected and are a definite (albeit often slow) memory leak. Substitution data and metadata should be decoded into a string keys map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant