Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Website layout is broken in Chrome by this extension #165

Open
Magikarplvl4 opened this issue Feb 22, 2020 · 16 comments
Open

Issue: Website layout is broken in Chrome by this extension #165

Magikarplvl4 opened this issue Feb 22, 2020 · 16 comments
Assignees
Labels
bug this item causes errors that make the project unusable discussion open ended forum to keep some issues down enhancement this item makes the project better in some way help-wanted outside assistance is recommended for this item question requests that are questions, rather than informative statements

Comments

@Magikarplvl4
Copy link

Magikarplvl4 commented Feb 22, 2020

If experiencing this issue still, please do the following →

29 MAR 2020 09:40 PM — To fix, enable Developer mode in Web to Plex's Advanced settings

Describe the error

Its look like sites that aren't the Web to Plex website getting broken by the last version of this plugin. if a unstall the plugin everything is fine.

Edit: It looks like sites that aren't Web to Plex are broken by the latest version. If I uninstall the extension, everything works fine.

To Reproduce

  1. Go to a website (for example GitHub)
  2. See error

Estimated location

Uncaught SyntaxError: Unexpected token '<' VM72:18
0P

Screenshots

image
image

Extension Information

  • Version: 4.1.2.4
  • Source: store
  • Browser: chrome
@Magikarplvl4 Magikarplvl4 added bug this item causes errors that make the project unusable enhancement this item makes the project better in some way help-wanted outside assistance is recommended for this item labels Feb 22, 2020
@Magikarplvl4 Magikarplvl4 changed the title Issue: [Everything Broke] Issue: Website layout are broken in chrome by this plugin :( Feb 22, 2020
@Ephellon
Copy link
Collaborator

Hi. Not able to reproduce this error. Could you take a look at your console with Developer Mode enabled please?

Domain not acknowledged "github.com"
image

@Ephellon
Copy link
Collaborator

image

@Ephellon Ephellon changed the title Issue: Website layout are broken in chrome by this plugin :( Issue: Website layout is broken in Chrome by this extension Feb 22, 2020
@Ephellon
Copy link
Collaborator

image

@Ephellon
Copy link
Collaborator

Ephellon commented Feb 23, 2020

I'm not sure if this is a language error (maybe it runs on sites not in English?). Normally, there would be an injected stylesheet from the extension →

Can't find injected stylesheet (Tweakers → https://tweakers.net)
image


Found injected stylesheet (Web to Plex → https://webtoplex.github.io)
image

@Ephellon Ephellon added discussion open ended forum to keep some issues down question requests that are questions, rather than informative statements labels Feb 23, 2020
@Ephellon
Copy link
Collaborator

The unexpected token error VM72:18 can be from anything running eval.

Assuming error is in 0P — it's the only script that embeds CSS

@Ephellon
Copy link
Collaborator

Ephellon commented Feb 27, 2020

Hi @PotatoQuality, could you take a look at my comment?

@Magikarplvl4
Copy link
Author

Hi @Ephellon, issues as being fixed after reinstalling the plugin. Thanks for your quick help <3

@Ephellon Ephellon added the chrome-only requests that involve only the chromium version label Mar 29, 2020
@Ephellon
Copy link
Collaborator

Not sure how this keeps happening...

@Ephellon Ephellon reopened this Mar 30, 2020
@Ephellon
Copy link
Collaborator

Notes to self:

  1. plugn.js runs normally, though it still injects on sites not run (most likely the culprit)
  2. All CSS files require the web-to-plex class to be present in some form or fashion...
  3. All domains not accepted kill quietly (as intended)

@Ephellon
Copy link
Collaborator

ok that is really weird. As soon as I turn on developer mode and refresh the IMDB page the format is fine. I'm gonna do it without refreshing the page.

Originally posted by @sp00kie in #168.605748176

It seems Developer mode fixes the issue, but no idea why... Will investigate

@Ephellon
Copy link
Collaborator

Possibly remote styling, though it still doesn't recreate the problem for me...

@Ephellon
Copy link
Collaborator

Fixed. Problem was in plugn.js as suspected. Remote calls were not filtered and inserted HTML

@Ephellon
Copy link
Collaborator

Reopening so that I can pin the issue for other users to see

@Ephellon Ephellon reopened this Mar 30, 2020
@Ephellon Ephellon pinned this issue Mar 30, 2020
@Simpuhl
Copy link

Simpuhl commented Apr 29, 2020

All websites are broken unless i uninstall or don't allow addin to access that website.

Why does it need access to all websites anyway? it should only need the ones it works with.

I really liked the old 3.4 version, so much simpler.

@Ephellon
Copy link
Collaborator

Ephellon commented Apr 29, 2020

FAQs — Why does the extension want access to all sites?

This permission is used to communicate with HTTPS served pages. In latent terms, if you want to use https://localhost:32400 (Plex), the extension needs permission to communicate with https://localhost. By accessing all URLs, sites can be added much easier, without having to send multiple prompts for access to the same site (i.e. HTTPS v. HTTP served pages).

@Ephellon Ephellon removed the chrome-only requests that involve only the chromium version label May 9, 2020
@Luckz
Copy link

Luckz commented Oct 28, 2020

Uncaught SyntaxError: Unexpected token '<'

6 Refused to load the font '<URL>' because it violates the following Content Security Policy directive: "font-src github.githubassets.com".

165:1 Refused to load the font 'https://webtoplex.github.io/font/Plex.woff2' because it violates the following Content Security Policy directive: "font-src github.githubassets.com".

165:1 Refused to load the font 'https://webtoplex.github.io/font/Plex.woff' because it violates the following Content Security Policy directive: "font-src github.githubassets.com".

165:1 Refused to load the font 'https://webtoplex.github.io/font/Plex.bold.woff2' because it violates the following Content Security Policy directive: "font-src github.githubassets.com".

165:1 Refused to load the font 'https://webtoplex.github.io/font/Plex.bold.woff' because it violates the following Content Security Policy directive: "font-src github.githubassets.com".

165:1 Refused to load the font 'https://github.com/font/Glyphicons.woff' because it violates the following Content Security Policy directive: "font-src github.githubassets.com".

165:1 Refused to load the font 'https://webtoplex.github.io/font/Glyphicons.woff' because it violates the following Content Security Policy directive: "font-src github.githubassets.com".

image

image

Still really crazy without that dev mode. (you wrote about it only here: webtoplex#5 (comment) ; it should probably be on by default while this version is so unstable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug this item causes errors that make the project unusable discussion open ended forum to keep some issues down enhancement this item makes the project better in some way help-wanted outside assistance is recommended for this item question requests that are questions, rather than informative statements
Projects
None yet
Development

No branches or pull requests

4 participants