New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SolidOs should be able to let users have more Bookmark instances #487

Open

timea-solid opened this issue Mar 29, 2022 · 2 comments

Labels

discussion enhancement

Member

timea-solid commented Mar 29, 2022 •

edited

Loading

This is at the moment limited here: https://github.com/solid/solid-ui/blob/23e59b8bf7463376735665cfd2376400072ece71/src/chat/bookmarks.js#L103 in code
Make sure to change the tests here: https://github.com/solid/solid-ui/blob/23e59b8bf7463376735665cfd2376400072ece71/test/unit/chat/bookmarks.test.ts#L63 accordingly.
However, we need to describe how to reconcile this on frontend, in ui too.

Contributor

jeff-zucker commented Mar 29, 2022

See https://gitter.im/solid/solidos?at=6241820399d94f5f0c70c091 and replies for discussion.

We should be able to have any number of instances of a type for all types, not just bookmarks.

bourgeoa added the enhancement label

Contributor

bourgeoa commented Apr 5, 2023

We should be able to have any number of instances of a type for all types, not just bookmarks.

I think it is the case except for bookmarks. I can have many Chats, or meeting or trackers

bourgeoa added the discussion label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment