Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FolderPane is not refreshed properly after deleting a resource #71

Closed
megoth opened this issue May 6, 2019 · 5 comments
Closed

FolderPane is not refreshed properly after deleting a resource #71

megoth opened this issue May 6, 2019 · 5 comments
Labels

Comments

@megoth
Copy link
Contributor

megoth commented May 6, 2019

No description provided.

@megoth megoth added the bug label May 6, 2019
@Vinnl
Copy link
Contributor

Vinnl commented May 7, 2019

I think this could theoretically be resolved by adding a change listener (e.g. kb.updater.addDownstreamChangeListener) for every object in a folder. node-solid-ws should send a notification through WebSockets that a file has been deleted, but after debugging it a bit with @michielbdejong, it appears that that does not work due to the following bug: nodeSolidServer/node-solid-ws#4

Thus, I think this issue is blocked by that one.

@Vinnl Vinnl removed their assignment May 27, 2019
timea-solid added a commit to SolidOS/folder-pane that referenced this issue Sep 24, 2021
timea-solid added a commit that referenced this issue Sep 24, 2021
@timbl
Copy link
Contributor

timbl commented Sep 26, 2021

Surely the folder pane only has to listen to changes in the folder resource itself, not all the children?

@timea-solid
Copy link
Member

Deleting a resource is triggered in the internal-pane part of solid-panes, which in turn should affect the display of the immediate, parent folder, displayed in the folder-pane. So only the div of that resource has to be rerendered, which is part of the folder-pane.

@timbl
Copy link
Contributor

timbl commented Oct 2, 2021

In this bug, how was the resource deleted? Using the internals pane, as the folder pane itself does not have a delete function. Assume something out of the pane itself. So we have to listen for a change.

@timbl
Copy link
Contributor

timbl commented Oct 2, 2021

Fixed by SolidOS/folder-pane#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants