Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential buffer overflow in Network.cpp #257

Open
Timmmm opened this issue Aug 4, 2024 · 1 comment
Open

Potential buffer overflow in Network.cpp #257

Timmmm opened this issue Aug 4, 2024 · 1 comment

Comments

@Timmmm
Copy link

Timmmm commented Aug 4, 2024

At least for the Inkplate 10 Google Calendar example your Network::getData() function just loops blindly writing to the output buffer. I can see no bounds checking mechanism.

I thought that might be the cause of #256 but sadly not; my data is like 200k and the buffer is 2MB. Still, you should probably fix that.

@rsoric
Copy link
Contributor

rsoric commented Aug 6, 2024

Hi @Timmmm ,

noted, we will be looking into this and hopefully publish a quick fix in the near future

-Rob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants